From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Sat, 31 Oct 2026 07:58:20 GMT
Subject: Re: [PATCH v4 2/4] imap-send: accept messages with Subject before Date
Message-ID: <CAHwyqnWM_GDhN_OSCrrwsuxuqwnc+mxi17H6Gut4mA=hAPPNFA@mail.gmail.com>
In-Reply-To: <xmqqqzh6u7i3.fsf@gitster.g>

> > +static bool has_required_headers(const char *line)
> > +{
> > +     bool from = false, date = false, subject = false;
> > +
> > +     while ((line = strchr(line, '\n')) && *++line != '\n') {
> > +             if (starts_with(line, "From: "))
> > +                     from = true;
> > +             else if (starts_with(line, "Date: "))
> > +                     date = true;
> > +             else if (starts_with(line, "Subject: "))
> > +                     subject = true;
> > +     }
> > +     return from && date && subject;
> > +}
>
> The above assumes that an empty line that denotes the end of the
> header can be detected by looking for '\n\n' in the line[].  So this
> may be scanning thru to the end of the message including the body,
> because each and every line ends with CRLF and there is no two
> consecutive LF appearing in the line.
>
> I admit that it was eons ago I read RFCs on IMAP (like RFC 2060),
> but I recall that its definition explicitly called for CRLF line
> endings, and existing code in imap-send.c before these patches seems
> to expect that it is reading CRLF delimited lines.

Thanks for pointing this out, I'll take a look.


Harald