From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Fri, 25 Sep 2026 21:43:15 GMT
Subject: Re: [PATCH] ci: point leak-sanitizer failures at the actual test and error
Message-ID: <CAHwyqnW83nMOcYUJrh8pHT+UT59Kh7kvWOg-j0UqTany2FBvqw@mail.gmail.com>
In-Reply-To: <09549A0E-D5FF-465C-A933-F144A19D14E4@gmail.com>

> > +github_escape_message_ () {
> > +    sed -e ':a' -e 'N' -e '$!ba' -e 's/%/%25/g' -e 's/\r/%0D/g' -e 's/\n/%0A/g'
> > +}
> > +
> > +find_test_case_line_ () {
> > +    grep -n -F -- "$1" "$TEST_DIRECTORY/$github_markup_script_name" |
> > +    head -n 1 | cut -d: -f1
> > +}
> > +
> > +github_annotation_ () {
> > +    echo >>$github_markup_output "::$1 file=$2,line=$3::$4"
> > +}
>
> Without commenting on the rest, introducing the helpers first might make the important patch easier to read.

Good point!


Harald