From: Barry Wardell <barry.wardell@gmail.com>
Date: Sat, 03 Mar 2012 19:45:47 GMT
Subject: Re: [PATCH] git-svn: Simplify calculation of GIT_DIR
Message-ID: <CAHrK+Z9fRQqLSY=3kc+8WkifTy1mJoA5ZFyGjXbdS8SXg9v=9w@mail.gmail.com>
In-Reply-To: <1330799233.691.40.camel@centaur.lab.cmartin.tk>

On Sat, Mar 3, 2012 at 6:27 PM, Carlos Martín Nieto <cmn@elego.de> wrote:
>
> > -# make sure we're always running at the top-level working directory
> > +# Access an existing repository
>
> Is there a reason making sure we're at the top-level dir isn't necessary
> anymore?

No, in fact it is still necessary.

> >  unless ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) {
> > -     unless (-d $ENV{GIT_DIR}) {
> > -             if ($git_dir_user_set) {
> > -                     die "GIT_DIR=$ENV{GIT_DIR} explicitly set, ",
> > -                         "but it is not a directory\n";
> > -             }
> > -             my $git_dir = delete $ENV{GIT_DIR};
> > -             my $cdup = undef;
> > -             git_cmd_try {
> > -                     $cdup = command_oneline(qw/rev-parse --show-cdup/);
> > -                     $git_dir = '.' unless ($cdup);
> > -                     chomp $cdup if ($cdup);
> > -                     $cdup = "." unless ($cdup && length $cdup);
> > -             } "Already at toplevel, but $git_dir not found\n";
> > -             chdir $cdup or die "Unable to chdir up to '$cdup'\n";
>
> Here you delete a chdir to the top-level directory, just as you deleted
> the comment above, yet in the commit message you don't explain why this
> isn't necessary anymore. Doesn't the rest of the code still assume that
> it's running at the top-level dir?


Yes, you're right. I will restore the chdir and submit a new patch.

Barry