From: Sangeeta <sangunb09@gmail.com>
Date: Mon, 09 Nov 2020 15:19:51 GMT
Subject: Re: [Outreachy][PATCH v6] diff: do not show submodule with untracked files as "-dirty"
Message-ID: <CAHjREB4=ESipt0r00WmueTH8h+2zQxLjJhky72M6dF-EX3WafQ@mail.gmail.com>
In-Reply-To: <20201107111002.GA21309@danh.dev>

Hey Danh,


> > diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> > index ca04fac417..9104d1946d 100755
> > --- a/t/t3701-add-interactive.sh
> > +++ b/t/t3701-add-interactive.sh
> > @@ -765,6 +765,11 @@ test_expect_success 'setup different kinds of dirty submodules' '
> >       cat >expected <<-\EOF &&
> >       dirty-both-ways
> >       dirty-head
> > +     EOF
> > +     git -C for-submodules diff-files --name-only --ignore-submodules=none >actual &&
> > +     cat >expected <<-\EOF &&
> > +     dirty-both-ways
> > +     dirty-head
>
> This will throw-away above change to "expected", I think this is not
> what you expected to write!

I am sorry I couldn't understand what you mean by that. I think that
is what I expected to write. I want those changes to be in "expected".

Thanks,
Sangeeta