From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Thu, 18 Feb 2021 03:11:37 GMT
Subject: Re: [RFC PATCH 3/7] t3705: add tests for `git add` in sparse checkouts
Message-ID: <CAHd-oW6nseo-uEuQL0DxykJQevXyt9xX5kQ7Cy0T2YXqzgKVJg@mail.gmail.com>
In-Reply-To: <CAPig+cT_ASSSe0jzEWiW_EPEa5FfHigfM+6fGQyG_kwj57XPfQ@mail.gmail.com>

On Wed, Feb 17, 2021 at 8:22 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Wed, Feb 17, 2021 at 6:04 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Matheus Tavares <matheus.bernardino@usp.br> writes:
> > > +for opt in "" -f -u --ignore-removal
> > > +do
> > > +     if test -n "$opt"
> > > +     then
> > > +             opt=" $opt"
> > > +     fi
> > > +     test_expect_success "git add$opt does not update SKIP_WORKTREE entries" '
> >
> ... A more idiomatic way to do this would
> have been:
>
>     for opt in "" -f -u --ignore-removal
>     do
>         test_expect_success " git add${opt:+ $opt} does ..." '

That's much better, thanks :)