From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Mon, 08 Jul 2019 22:30:22 GMT
Subject: Re: mt/dir-iterator-updates, was Re: What's cooking in git.git (Jul 2019, #01; Wed, 3)
Message-ID: <CAHd-oW4AMn4UABfzeVcJSNM8AxxDTw5d8=HUTZnXRMwSxgqREQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1907052009590.44@tvgsbejvaqbjf.bet>

On Fri, Jul 5, 2019 at 3:17 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> Hi Matheus,
>
> On Fri, 5 Jul 2019, Matheus Tavares Bernardino wrote:
> >
> > So, should I send a fixup patch removing find_recursive_symlinks() or
> > reroll the series? There's also the option to use stat()+lstat() to
> > reduce calls to this function, but it doesn't solve the problem on
> > Windows, anyway.
>
> I would suggest to send another iteration that removes
> `find_recursive_symlinks()`. Junio most likely interpreted my objections
> as a veto against advancing the current iteration to `next`, meaning that
> you're good to even rewrite completely in the next iteration, should you
> feel the need to. No need for "Oops, fix that" follow-up commits at this
> stage.

OK, thanks! I'll send a v8, then, removing the circular symlink section, ASAP.

> Ciao,
> Dscho

Best,
Matheus