From: Tyler Cipriani Date: Sun, 06 Sep 2026 20:24:10 GMT Subject: Re: [PATCH 0/2] push: fix --force-if-includes consulting wrong ref Message-ID: In-Reply-To: On Sat, Sep 5, 2026 at 12:59 PM Ben Knoble wrote: > Thanks for the advice changes! One small nit on the first > patch you can ignore if you choose. Good call on updating the log message for PATCH 1/2. I'll note that detached HEAD is already rejected in v2. > At first I hoped we might be able to stop rejecting detached > HEAD pushes, but some further thought begs the question: > what reflog would we use? > HEAD’s is too broad :) > > So this may be all we can do for now. It looks like that's the conclusion they reached on the original patchset, too, based on my re-reading of the thread[0]. HEAD's reflog is too broad for the --force-if-includes check (with the acknowledged downside being that --force-if-includes isn't useful for the detached HEAD case.) [0]: > At least I can replace my intuition with reading the error message again. :) Thank you for the review!