From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Thu, 12 Sep 2013 08:41:29 GMT
Subject: Re: [PATCH] Windows: Do not redefine _WIN32_WINNT
Message-ID: <CAHGBnuPXPrpfdQYuwHz-AhLWcY3fx7KoWQ9L+RRz9hPnoQL4Dg@mail.gmail.com>
In-Reply-To: <xmqq61u7rpr3.fsf@gitster.dls.corp.google.com>

On Wed, Sep 11, 2013 at 11:51 PM, Junio C Hamano <gitster@pobox.com> wrote:

> It seems that compat/poll/poll.c also defines _WIN32_WINNT (but only
> with _MSC_VER defined).  The change to git-compat-util.h in this
> patch avoids redefinition for both MinGW and MSVC case.  Do you also
> need to have this, too?

In my patch I did not change poll.c because I did only check this
issue with MinGW, not MSVC, so I never ran into the _MSC_VER code
path. Back in 1.8.3 git-compat-util.h did define _WIN32_WINNT for both
MinGW and MSVC, which is why in my patch I had to add the #ifndef /
#endif. But I believe it's good to have these guards for both MinGW
and MSVC, actually.

> Here is what I tentatively queued on top of the three from Karsten,
> and your "Fix stat definitions".

Looks good to me, thanks!

-- 
Sebastian Schuberth