From: Sebastian Schuberth Date: Sun, 05 Jan 2014 13:42:08 GMT Subject: Re: [PATCH v2 3/4] Speed up is_git_command() by checking early for internal commands Message-ID: In-Reply-To: <371D58A5-4640-4125-9B69-E9A7B03B347F@acm.org> On Fri, Jan 3, 2014 at 5:49 PM, Kent R. Spillner wrote: >> Since 2dce956 is_git_command() is a bit slow as it does file I/O in the >> call to list_commands_in_dir(). Avoid the file I/O by adding an early >> check for internal commands. > > Considering the purpose of the series is it better to say "builtin" instead of "internal" in the commit message? True, I'll fix this in a re-rool. -- Sebastian Schuberth