From: Jon Seymour <jon.seymour@gmail.com>
Date: Mon, 28 May 2012 21:39:29 GMT
Subject: Re: [PATCH v7 6/9] submodule: fix detection of invalid submodule URL
Message-ID: <CAH3Anrrg4Fc5GXB_VwOXRfwP=hx5Xn5bqimP56oDB0USn7c4Cg@mail.gmail.com>
In-Reply-To: <4FC3CB7E.6000501@kdbg.org>

On Tue, May 29, 2012 at 5:01 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 27.05.2012 17:34, schrieb Jon Seymour:
>
> Without understanding in detail what this series is about, I would guess
> that the previous two case arms are not very Windows friendly. Does the
> right thing happen when $remoteurl is "c:/path/to/remote"? Would it help
> to use is_absolute_path?
>
>        if is_absolute_path "$remoteurl"
>        then
>                variant="${remoteurl#*/}"
>        else
>                case "$remoteurl" in
>                ...other cases go here...
>                esac
>        fi
>
> -- Hannes

Thanks, I will investigate this as an alternative.

jon.