From: Jon Seymour <jon.seymour@gmail.com>
Date: Mon, 21 May 2012 22:20:07 GMT
Subject: Re: [PATCH v3 2/4] submodule: support superproject origin URLs of the form ./foo/bar or ../foo/bar
Message-ID: <CAH3AnrrEnLEnN=EgzaDjFtN6r9RBpTmPNTX96QiMtGz9J12eCQ@mail.gmail.com>
In-Reply-To: <CAH3AnrqBeD3JisjoK2dqnPWcBAFTxB5NYgRkfSPqb-CS8a0hsw@mail.gmail.com>

On Tue, May 22, 2012 at 2:35 AM, Jon Seymour <jon.seymour@gmail.com> wrote:
> On Mon, May 21, 2012 at 11:31 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>
> Mmmm. Better hold off on this one for the moment, I have detected a
> break during a subsequent git submodule update that my selection of
> regression tests didn't pick up. The issue is that the URL used for
> cloning the submodule during the update is now not correct.
>
> jon.

I guess the issue here is that whereas the origin url of the submodule
(as in remote.origin.url in the submodule) should be relative to the
submodule's working tree, it might actually be better to keep
submodule.{modulename}.url relative to the working directory of
superproject (which is current behaviour).

Thoughts?

jon.