From: Jon Seymour <jon.seymour@gmail.com>
Date: Sat, 06 Aug 2011 09:17:26 GMT
Subject: Re: [PATCH 01/40] test-cleaner: automate whitespace cleaning of test scripts
Message-ID: <CAH3AnrpkNRU=cXx2VN+cLb-R=d3Exr6fteQr=N-WJuq1E=JqzA@mail.gmail.com>
In-Reply-To: <1312620294-18616-1-git-send-email-jon.seymour@gmail.com>

On Sat, Aug 6, 2011 at 6:44 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> This script allows the automated cleaning of test scripts.
>
> Any whitespace fixups of a test script that do not effect the
> exit status or output of the test are assumed to be safe
> and are automatically committed.

Actually, this is not true - commits are generated, if the file
matches the filtering criteria for the fix subcommand specified.

> If no arguments are supplied, file arguments are read from stdin.

Should I use - for instead?

> +
> +fix_whitespace_auto()
> +{
> +       check_whitespace "$@" 2>/dev/null | grep "^AUTO" | fix_whitespace
> +}
> +
> +fix_whitespace_auto()
> +{
> +       check_whitespace "$@" 2>/dev/null | grep "^MANUAL" | fix_whitespace
> +}

Both these need cut -f1 before the fix_whitespace stage.

jon.