From: Jon Seymour <jon.seymour@gmail.com>
Date: Sun, 03 Jun 2012 09:51:00 GMT
Subject: Re: [PATCH v7 6/9] submodule: fix detection of invalid submodule URL
Message-ID: <CAH3Anrp_aUR2O_iEwxHu4bRs83U58X6QsY6+SJ56NXKEC7LA5Q@mail.gmail.com>
In-Reply-To: <CAH3Anrrg4Fc5GXB_VwOXRfwP=hx5Xn5bqimP56oDB0USn7c4Cg@mail.gmail.com>

On Tue, May 29, 2012 at 7:39 AM, Jon Seymour <jon.seymour@gmail.com> wrote:
> On Tue, May 29, 2012 at 5:01 AM, Johannes Sixt <j6t@kdbg.org> wrote:
>> Am 27.05.2012 17:34, schrieb Jon Seymour:
>>
>> Without understanding in detail what this series is about, I would guess
>> that the previous two case arms are not very Windows friendly. Does the
>> right thing happen when $remoteurl is "c:/path/to/remote"? Would it help
>> to use is_absolute_path?
>>
>>        if is_absolute_path "$remoteurl"
>>        then
>>                variant="${remoteurl#*/}"
>>        else
>>                case "$remoteurl" in
>>                ...other cases go here...
>>                esac
>>        fi
>>
>> -- Hannes
>
> Thanks, I will investigate this as an alternative.
>

I did investigate is_absolute_path for the v8 roll of this series, but
I found it wasn't suitable because it doesn't classify URLs of the
form user@host:repo as absolute. You can find the alternative I did
use in v8 3/4.

Regards,

jon.