From: Jon Seymour Date: Wed, 03 Aug 2011 13:24:21 GMT Subject: Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain. Message-ID: In-Reply-To: On Wed, Aug 3, 2011 at 10:46 PM, Jon Seymour wrote: > On Wed, Aug 3, 2011 at 3:27 PM, Christian Couder > wrote: >> On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote: >>> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder >>> >>> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a >>> call to a function bisect_mode() that does the same thing. >> >> Yeah, I think it would be a good idea to have a bisect_mode() function. >> I don't like very much to blindly call some code when we might not need it. >> > Mmmm. Actually, there is a neater way to do this. I'll such use the existence of BISECT_HEAD to inform the implementation of bisect_mode(). This avoids the need for a separate .git/BISECT_MODE file. jon.