From: Jon Seymour Date: Wed, 03 Aug 2011 15:24:12 GMT Subject: Re: [PATCH v14 5/8] bisect: introduce --no-checkout support into porcelain. Message-ID: In-Reply-To: On Wed, Aug 3, 2011 at 11:16 PM, Jon Seymour wrote: > On Wed, Aug 3, 2011 at 9:16 AM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> Jon Seymour writes: >> >> Further polishing we may want to do while it is still in pu/next I can >> think of off the top of my head are: >> >>  - In this mode, I can bisect the history even inside a bare repository, >>   as the whole point of --no-checkout is that the mode does not require a >>   working tree. I however suspect "git bisect" requires working tree. Is >>   this something we want to fix? >> > > I agree, that would be useful. Haven't tried it yet but I'll see what > happens.I may issue changes for this as separate commit that can be > squashed later, if required,  once it has been reviewed. > I had a quick go at doing this, but haven't been able to test it fully. At a minimum it will require that we relax the barriers in git-bisect.sh and git.c that prevent git-bisect and bisect--helper running without a working tree. Other paths in these modules will need to be checked to see that they don't have an implicit assumption that a working tree is available. I won't have time to tackle this properly until the weekend. jon.