From: Jon Seymour Date: Wed, 03 Aug 2011 12:46:54 GMT Subject: Re: [PATCH v13 5/8] bisect: introduce --no-checkout support into porcelain. Message-ID: In-Reply-To: <201108030727.04246.chriscool@tuxfamily.org> On Wed, Aug 3, 2011 at 3:27 PM, Christian Couder wrote: > On Tuesday 02 August 2011 16:41:13 Jon Seymour wrote: >> On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder >> >> If I was to do this, I'd prefer to change uses of $BISECT_MODE with a >> call to a function bisect_mode() that does the same thing. > > Yeah, I think it would be a good idea to have a bisect_mode() function. > I don't like very much to blindly call some code when we might not need it. > Ok, I'll do that, though it does mean that during a bisect run invocation, for example, the file BISECT_MODE file will be read log(N) times instead of just once. Obviously, in the grand scheme of things this is not a huge cost. I could use a variable to avoid hitting the file each time, but if I do that I am going to have to ensure it is blank to start with which means I will need at least an assignment in the place where that statement is now. jon.