From: Ezekiel Newren Date: Sat, 20 Sep 2025 17:41:43 GMT Subject: Re: [PATCH v3 01/10] xdiff: delete static forward declarations in xprepare Message-ID: In-Reply-To: On Sat, Sep 20, 2025 at 11:16 AM Junio C Hamano wrote: > > Best-viewed-with: --color-moved > > Two comments. > > - This is a bit unusual to see in the trailer. I'm still not sure what the etiquette is for including those kinds of flags in a commit message. Could you show me my full commit message as a response with your preferred way of adding those flags in a commit message? please. > - It turned out that it was a very effective way to spot a typo for > me. You should try it yourself before you send out your patches > ;-). Huh, I have viewed this patch with --color-moved dozens of times. I think CLion (My IDE of choice for C) "fixed" that for me, and I didn't notice until you pointed it out. Elijah missed it too. Maybe my terminal needs a more extreme contrast, so it's easier for me to spot things like that. > If I do not spot any other issues in the series, I may just "rebase > -i" to correct this single line to reduce the risk of mistakes, > instead of asking you to send an update. We'll see. If that is the only problem then I would prefer that you fix that single mistake, so I don't flood the mailing list.