From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Thu, 06 Nov 2025 23:14:30 GMT
Subject: Re: [PATCH v2 03/10] xdiff: make xrecord_t.ptr a uint8_t instead of char
Message-ID: <CAH=ZcbDTnvgrkfKYe_uyPHh5Xd2Pbw4532UvNcz+nz+rpbhUiQ@mail.gmail.com>
In-Reply-To: <3f7bbb5e-0d67-4ef2-82fb-e0b00683c178@gmail.com>

On Thu, Nov 6, 2025 at 3:55 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> On 29/10/2025 22:19, Ezekiel Newren via GitGitGadget wrote:
> > @@ -156,8 +156,8 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_
> >                       if (XDL_ALLOC_GROW(xdf->recs, xdf->nrec + 1, narec))
> >                               goto abort;
> >                       crec = &xdf->recs[xdf->nrec++];
> > -                     crec->ptr = prev;
> > -                     crec->size = (long) (cur - prev);
> > +                     crec->ptr = (uint8_t const *)prev;
> > +                     crec->size =(long) ( cur - prev);
>
> The changes to crec->size here look unintentional

I agree. I'll change that.