From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Wed, 24 Sep 2025 14:52:10 GMT
Subject: Re: [PATCH v5 05/13] xdiff: delete superfluous local variables that alias fields in xrecord_t
Message-ID: <CAH=ZcbBtL5xVKhHGKeb2PkCjNE4dDEO_jc0XsxwR2-jnX-f8JA@mail.gmail.com>
In-Reply-To: <3d03290e-bfad-41de-9735-91b126ae9e57@gmail.com>

On Wed, Sep 24, 2025 at 4:21 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> On 23/09/2025 22:24, Ezekiel Newren via GitGitGadget wrote:
> > From: Ezekiel Newren <ezekielnewren@gmail.com>
> >
> > Use the type xrecord_t as the local variable for the functions in the
> > file xdiff/xemit.c.
>
> This explains what the change is but not why it is being made. Commit
> messages in this project are expected to explain the reason for the
> change so that future readers can understand why a change was made.

"Use the type xrecord_t as the local variable for the functions in the
file xdiff/xemit.c. This helps tools like ctags or modern IDE's more
accurately follow the usage of xrecord_t."

Is this commit message good enough?