From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Wed, 24 Sep 2025 14:34:54 GMT
Subject: Re: [PATCH v6 0/9] Introduce Rust and announce that it will become mandatory
Message-ID: <CAH=ZcbBjL09Mk3AXBSgmZGvmFtU3Roc2P5rbQsZ-U5DBHYSs7w@mail.gmail.com>
In-Reply-To: <aNN7dG6oLrv2Mokq@pks.im>

On Tue, Sep 23, 2025 at 11:02 PM Patrick Steinhardt <ps@pks.im> wrote:
>
> On Tue, Sep 23, 2025 at 02:15:35PM -0600, Ezekiel Newren wrote:
> > On Tue, Sep 23, 2025 at 3:45 AM Patrick Steinhardt <ps@pks.im> wrote:
> > Your patch series has 2 critical problems:
> >   * meson doesn't check for "is windows and using msvc" -> <crate>.lib
> > else lib<crate>.a
>
> I didn't wire Windows up yet, so this is a known omission. It's not
> handled in the Makefile yet, either. My plan here was to tackle Windows
> support as the immediate next step once this patch series lands.
>
> Would that be fine with you?

So long as you're aware, I'm fine with it being fixed later. I believe
that Makefile doesn't ever use msvc in the github workflows and you'd
only need to tell meson to look for <crate>.lib since cargo will
produce that if it's using the Rust toolcahin x86_64-pc-windows-msvc.
Also you'd need to update your cargo-meson.sh script to merely look
for <crate>.lib instead of lib<crate>.a and move it.

> >   * Using the name "git" for the crate is problematic because both
> > Make and Meson already produce libgit.a which is different from the
> > libgit.a that cargo is producing. Change the name in Cargo.toml from
> > "git" to "gitcore".
>
> I wasn't quite happy with the "git" name anyway, so I'll happily take
> "gitcore" instead.

Ok.

Thanks.

Ezekiel.