From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Wed, 01 Oct 2025 17:22:44 GMT
Subject: Re: [PATCH v7 5/9] varint: use explicit width for integers
Message-ID: <CAH=ZcbBQk9xmTF-m6tX6F+PRmnUSoevyFFvK-fAc3uzL3NvqSQ@mail.gmail.com>
In-Reply-To: <037d8685-6521-4ac1-8251-d93e8a1d7081@app.fastmail.com>

On Tue, Sep 30, 2025 at 7:34 AM Kristoffer Haugsbakk
<kristofferhaugsbakk@fastmail.com> wrote:
>
> On Thu, Sep 25, 2025, at 08:30, Patrick Steinhardt wrote:
> > The varint subsystem currently uses implcit widths for integers. On the
>
> s/implcit/implicit/
>
> > one hand we use `uintmax_t` for the actual value. On the other hand, we
> > use `int` for the length of the encoded varint.
> >
> > Both of these have known maximum vaules, as we only support at most 16
>
> s/vaules/values/

Other than the typos this looks good.