From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Fri, 19 Sep 2025 23:37:12 GMT
Subject: Re: [PATCH v3 00/10] Cleanup xdfile_t and xrecord_t in xdiff.
Message-ID: <CAH=ZcbAnkrVTB3yi203t9-yq3LM+ucbvtu6Hh0Sp20YU3FeQZQ@mail.gmail.com>
In-Reply-To: <CABPp-BEjX6Nw90P=sgaSVrKLJX9HW6A8P0fyadBD0snURc10fg@mail.gmail.com>

On Fri, Sep 19, 2025 at 5:31 PM Elijah Newren <newren@gmail.com> wrote:
> I read over this latest round and it addresses all my feedback from
> v1.  On top of all the nice code cleanups that this series provides, I
> appreciate the new detailed performance comparisons in the commit
> message in patch 8; while this series as a whole doesn't make the code
> appreciably faster yet, it's really cool that you've highlighted
> another potential performance optimization (beyond the hashing one you
> already highlighted elsewhere on the list) that we'll likely be able
> to realize once you get some further preparatory refactoring done.
> Looking forward to it.

Thanks for the positive feedback.

> I think this round is ready to merge to next.

I agree.