From: Ezekiel Newren Date: Thu, 02 Oct 2025 23:35:27 GMT Subject: Re: [PATCH v8 0/9] Introduce Rust and announce that it will become mandatory Message-ID: In-Reply-To: <20251002-b4-pks-rust-breaking-change-v8-0-3a89fd5b1ce7@pks.im> On Thu, Oct 2, 2025 at 1:30 AM Patrick Steinhardt wrote: > Range-diff versus v7: > > 1: 3f916bebd4 = 1: bf7b33291d meson: add infrastructure to build internal Rust library > 2: ed849dcfed = 2: 59e7879c63 Makefile: reorder sources after includes > 3: 955f262ef5 = 3: 635cebc0a6 Makefile: introduce infrastructure to build internal Rust library > 4: 7a90192b5a = 4: 43b50563cc help: report on whether or not Rust is enabled > 5: 9365a78efd ! 5: 37d03d7774 varint: use explicit width for integers > @@ Metadata > ## Commit message ## > varint: use explicit width for integers > > - The varint subsystem currently uses implcit widths for integers. On the > + The varint subsystem currently uses implicit widths for integers. On the > one hand we use `uintmax_t` for the actual value. On the other hand, we > use `int` for the length of the encoded varint. > > - Both of these have known maximum vaules, as we only support at most 16 > + Both of these have known maximum values, as we only support at most 16 > bytes when encoding varints. Thus, we know that we won't ever exceed > `uint64_t` for the actual value and `uint8_t` for the prefix length. > > 6: e7e0621b68 = 6: 0d265f9675 varint: reimplement as test balloon for Rust > 7: 8d8e9cb8a8 = 7: a6e0d668f0 BreakingChanges: announce Rust becoming mandatory > 8: 07dc8171ac = 8: 79470835fd ci: convert "pedantic" job into full build with breaking changes > 9: 708a0d3c67 = 9: 67f8dea13f ci: enable Rust for breaking-changes jobs > > --- > base-commit: 2462961280690837670d997bde64bd4ebf8ae66d > change-id: 20250904-b4-pks-rust-breaking-change-7167d9d3e37d I think it's ready to be merged.