From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Wed, 24 Sep 2025 15:10:49 GMT
Subject: Re: [PATCH v5 11/13] xdiff: rename rchg -> changed in xdfile_t
Message-ID: <CAH=ZcbA+MLbyNp3f7RbMFA6vrDZC6yRKVh7ryVer1Ozg3d4oSg@mail.gmail.com>
In-Reply-To: <82ee55d6-f8ae-4a88-84fc-47c6ce18139a@gmail.com>

On Wed, Sep 24, 2025 at 4:21 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> On 23/09/2025 22:24, Ezekiel Newren via GitGitGadget wrote:
> > From: Ezekiel Newren <ezekielnewren@gmail.com>
>
> I agree "changed" is a better name but the commit message should explain
> what "rchg" is used for so that someone who is not familiar with the
> code can understand why the change in name is desirable.

The field rchg (now 'changed') declares if a line in a file is changed
or not. A later commit will change it's type from 'char' to 'bool'
to make its purpose even more clear.

Something like that?