From: Michael Forney Date: Thu, 13 Aug 2020 21:16:42 GMT Subject: Re: [PATCH 2/2] submodule: use submodule repository when preparing summary Message-ID: In-Reply-To: On 2020-06-30, Michael Forney wrote: > I attached my best attempt at a test to trigger the error. The > probability of the test failing correctly (without the fix applied) > seems to depend on how many commits are present in submodule before > the first commit in the range of changed commits. This can be > controlled by adjusting the `seq 1 X` in the for loop. The lowest > number of commits with which I have been able to reproduce the bug is > 3, where it occurs around 1% of the time, and if I set it to 200, I > can reproduce the bug around 99% of the time. > > Can the bug fix be applied without a test? If not, hopefully someone > can volunteer to craft a reliable test (assuming that this is even > possible). Still looking for any help with this. It seems pretty clear that this is a bug (I am not the only one who has hit this), and I'd really like to see the issue fixed. I gave my best shot at a test, but I don't think it's acceptable to commit a test that gives a false positive some percentage of the time. I see that my patch is still blocked as "Needs tests" in the what's cooking summary, but I really don't know how to proceed from here.