From: Jonathan Tan <jonathantanmy@google.com>
Date: Mon, 28 Jan 2019 16:57:36 GMT
Subject: Re: [PATCH] object_as_type: initialize commit-graph-related fields of 'struct commit'
Message-ID: <CAGf8dgLzNJLrT-XW25=1SqJiH47hiTNVHf7-sx8efHw5oMnC7Q@mail.gmail.com>
In-Reply-To: <20190127130832.23652-1-szeder.dev@gmail.com>

On Sun, Jan 27, 2019 at 5:08 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> When the commit graph and generation numbers were introduced in
> commits 177722b344 (commit: integrate commit graph with commit
> parsing, 2018-04-10) and 83073cc994 (commit: add generation number to
> struct commit, 2018-04-25), they tried to make sure that the
> corresponding 'graph_pos' and 'generation' fields of 'struct commit'
> are initialized conservatively, as if the commit were not included in
> the commit-graph file.

Thanks for looking into this! The patch looks good to me.