From: Seyi Kuforiji <kuforiji98@gmail.com>
Date: Wed, 04 Mar 2026 19:29:01 GMT
Subject: Re: [PATCH v2 3/5] list-objects-filter: use oidmap_clear_with_free() for cleanup
Message-ID: <CAGedMte09S1FE2nX5SnamzqZyMGfme-kL0skZ+e+st-b2HbQMA@mail.gmail.com>
In-Reply-To: <xmqqjyvra9xg.fsf@gitster.g>

On Wed, 4 Mar 2026 at 16:31, Junio C Hamano <gitster@pobox.com> wrote:
>
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Agreed. But I think with the current status quo I'd rather drop this
> > patch though as it may otherwise make the reader scratch their head why
> > we do the exercise in the first place.
>
> I do not think too strongly either way myself, but you may be right.
>
> Unless we are dropping the "we optionally let you free the shell"
> traditional interface, it is of questionable value to use the new
> interface.
>
> Thanks.
>

Hello

Thank you so much for the reviews.

I'll send a new version dropping the [PATCH 3/5].

Thanks,
Seyi