From: Sverre Rabbelier Date: Wed, 21 Nov 2012 19:20:49 GMT Subject: Re: [PATCH v5 11/15] remote-testgit: make clear the 'done' feature Message-ID: In-Reply-To: <7vy5hu3h11.fsf@alter.siamese.dyndns.org> On Wed, Nov 21, 2012 at 10:11 AM, Junio C Hamano wrote: > I'd state it like this, but I may have guessed what Felipe intended > incorrectly. > > remote-testgit: advertise "done" feature and write "done" ourselves > > Instead of letting "fast-export" advertise the feature and ending > its stream with "done", do it ourselves. This way, it would make it > more clear to people who want to write their own remote-helper to > produce fast-export streams without using "fast-export > --use-done-feature" that they are supposed to end their stream with > "done". With that commit message: Acked-by: Sverre Rabbelier -- Cheers, Sverre Rabbelier