From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Fri, 18 Jan 2013 03:50:19 GMT
Subject: Re: [PATCH v2 7/8] git-remote-testpy: don't do unbuffered text I/O
Message-ID: <CAGdFq_jcp-XKoTkz0iVKiVb0csrfcmCWEEiTBC-c0Bg2HP+e3g@mail.gmail.com>
In-Reply-To: <6bc90f3afc86d53eb6e4b4d6b87f6afd20023769.1358448207.git.john@keeping.me.uk>

On Thu, Jan 17, 2013 at 10:54 AM, John Keeping <john@keeping.me.uk> wrote:
> -    sys.stdin = os.fdopen(sys.stdin.fileno(), 'r', 0)
> +    sys.stdin = os.fdopen(sys.stdin.fileno(), 'rb', 0)

It is not immediately obvious why you would open stdin in rb mode,
please add a comment.

--
Cheers,

Sverre Rabbelier