From: Sverre Rabbelier Date: Mon, 01 Aug 2011 09:58:48 GMT Subject: Re: [PATCH] For Real - Fixed pluralization in diff reports Message-ID: In-Reply-To: <4E362F8E.1050105@gmail.com> Heya, On Mon, Aug 1, 2011 at 06:46, Jon Forrest wrote: >        fprintf(options->file, "%s", line_prefix); >        fprintf(options->file, > -              " %d files changed, %d insertions(+), %d deletions(-)\n", > -              total_files, adds, dels); > +              " %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n", > +              total_files, total_files == 1 ? "" : "s", adds, adds == 1 ? > "" : "s", dels, > +               dels == 1 ? "" : "s"); >  } Also, this is rather detrimental to the i18n effort methinks? -- Cheers, Sverre Rabbelier