From: Sverre Rabbelier Date: Tue, 03 Apr 2012 02:00:58 GMT Subject: Re: [PATCHv2 0/2] fast-import: tighten parsing of mark references Message-ID: In-Reply-To: <1333417910-17955-1-git-send-email-pw@padd.com> On Mon, Apr 2, 2012 at 20:51, Pete Wyckoff wrote: > Also, I did the unit tests first, to make sure things were broken > as I expected.  You can squash it all together if you prefer. Nice series. I agree that it's good to be strict in what we accept (breaking from the "be liberal in what you accept" mantra), due to the importance of the input stream being parsed exactly right (as opposed to a browser, where it's better to not render something bold than to just break because a was missing). -- Cheers, Sverre Rabbelier