From: Sverre Rabbelier Date: Wed, 02 Nov 2011 23:35:12 GMT Subject: Re: t5800-*.sh: Intermittent test failures Message-ID: In-Reply-To: Heya, On Wed, Nov 2, 2011 at 00:02, Alex Riesen wrote: > On Tue, Nov 1, 2011 at 23:18, Junio C Hamano wrote: >> Alex Riesen writes: >> >>> On Sun, Sep 11, 2011 at 21:14, Ramsay Jones wrote: >>>> ... these hangs *are* the failures of which I speak!  Yes, the script >>>> doesn't get to declare a failure, but AFAIAC a hanging test (and it >>>> isn't the same test # each time) is a failing test. :-D >>> >>> Was there any outcome of this discussion? I'm asking because I >>> can reproduce this very reliably on a little server here. >> >> I do remember this discussion and recall seeing _no_ outcome. >> >> I did see the hang myself once or twice but did not and do not have a >> reliable reproduction. I have been waiting for somebody to raise the issue >> again ;-). >> > > I think I managed to bisect it (between 1.7.6 and 1.7.7): > > $ git bisect start v1.7.7 v1.7.6 > ... > $ git bisect good > a515ebe9f1ac9bc248c12a291dc008570de505ca is the first bad commit > commit a515ebe9f1ac9bc248c12a291dc008570de505ca > Author: Sverre Rabbelier > Date:   Sat Jul 16 15:03:40 2011 +0200 > >    transport-helper: implement marks location as capability > >    Now that the gitdir location is exported as an environment variable >    this can be implemented elegantly without requiring any explicit >    flushes nor an ad-hoc exchange of values. > >    Signed-off-by: Sverre Rabbelier >    Acked-by: Jeff King >    Signed-off-by: Junio C Hamano > > :100644 100644 1ed7a5651ef5a2320c56856b5a1fe784e178ab23 > e9c832bfd3da7db771cc2113027d3e590dc51d59 M      git-remote-testgit.py > :100644 100644 0cfc9ae9059ce121b567406d7941b71cd54b961c > 74c3122df1835c45a6b621205fb18b4fc89af366 M      transport-helper.c > > Sadly, I'm going to be able to repeat the test in about 20 hours. Ævar, this seems like something we could look at during the mini GitTogether in Amsterdam this Saturday, no? -- Cheers, Sverre Rabbelier