From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Fri, 15 Jul 2011 09:40:02 GMT
Subject: Re: [PATCH 2/3] fast-export: use object to uint32 map instead of "decorate"
Message-ID: <CAGdFq_guf8fa014t17KyNoEzpCAK-aG5BrpQ40tQ=1507OJ8bw@mail.gmail.com>
In-Reply-To: <20110714175211.GB21771@sigill.intra.peff.net>

Heya,

On Thu, Jul 14, 2011 at 19:52, Jeff King <peff@peff.net> wrote:
> Previously we encoded the "mark" mapping inside the "void *"
> field of a "struct decorate". It's a little more natural for
> us to do so using a data structure made for holding actual
> values.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> And this is an example of use. It doesn't save all that much code, but I
> think it's a little more natural. It can also save some bytes of the hash
> value in each entry if your pointers are larger than 32-bit.

Did you run any benchmarks on this?

-- 
Cheers,

Sverre Rabbelier