From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Mon, 04 Jul 2011 13:37:41 GMT
Subject: Re: [PATCH v2 15/20] transport-helper: use the new done feature where possible
Message-ID: <CAGdFq_gknRaWzZjOOZyE9WvgTLBGADDLb_WcxE3vfN+uRBztGw@mail.gmail.com>
In-Reply-To: <20110620114556.GA29818@elie>

Heya,

On Mon, Jun 20, 2011 at 13:45, Jonathan Nieder <jrnieder@gmail.com> wrote:
> What is this change about?  Is the plan to allow other commands after
> a fetch_with_import?  Sounds reasonable; I think it should be
> advertised in the log message, though.

Yeah, the order/granularity of these commits is perhaps suboptimal.
The actual changes is by now explained in "export is no longer always
the last command" and "change import semantics". Perhaps they should
just be squashed together?

> The disconnect_helper call writes the blank line that terminates the
> list of "import %s" commands to start the import, so there would need

Terminating the list of import commands isn't needed until the "change
import semantics" commit, in which a write_constant(data->helper->in,
"\n") is added.

-- 
Cheers,

Sverre Rabbelier