From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Mon, 22 Oct 2012 21:01:23 GMT
Subject: Re: [PATCH] remote-testgit: properly check for errors
Message-ID: <CAGdFq_gOb3GX1iZshGZahZEbj3RqQSEk8AN_hHXKyD5aHwfxYA@mail.gmail.com>
In-Reply-To: <1350939394-21622-1-git-send-email-felipe.contreras@gmail.com>

On Mon, Oct 22, 2012 at 1:56 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> diff --git a/git-remote-testgit.py b/git-remote-testgit.py
> index 5f3ebd2..b8707e6 100644
> --- a/git-remote-testgit.py
> +++ b/git-remote-testgit.py
> @@ -159,6 +159,11 @@ def do_import(repo, args):
>          ref = line[7:].strip()
>          refs.append(ref)
>
> +    print "feature done"

There's not enough context for me to see in which part of the code
this is, import or export? If you advertise 'feature done', shouldn't
you also print 'done' when you finish writing the fast-export stream?
If that's already the case feel free to ignore me :)

-- 
Cheers,

Sverre Rabbelier