From: Stefan Beller <sbeller@google.com>
Date: Thu, 09 Mar 2017 02:16:23 GMT
Subject: Re: [PATCH v2 07/11] submodule update: add `--init-active` switch
Message-ID: <CAGZ79kbyyJCZ7iP6c7RBgrv8NNSMjb9fov3eFazpOb2QL5aAcg@mail.gmail.com>
In-Reply-To: <20170309012345.180702-8-bmwill@google.com>

On Wed, Mar 8, 2017 at 5:23 PM, Brandon Williams <bmwill@google.com> wrote:
> The new switch `--init-active` initializes the submodules which are
> configured in `submodule.active` instead of those given as
> command line arguments before updating. In the first implementation this
> is made incompatible with further command line arguments as it is
> unclear what the user means by
>
>     git submodule update --init --init-active <paths>
>
> This new switch allows users to record more complex patterns as it saves
> retyping them whenever you invoke update.
>
> Based on a patch by Stefan Beller <sbeller@google.com>
>
> Signed-off-by: Brandon Williams <bmwill@google.com>



> @@ -568,7 +573,17 @@ cmd_update()
>
>         if test -n "$init"
>         then
> -               cmd_init "--" "$@" || return
> +               if test "$init" = "by_config"
> +               then
> +                       if test $# -gt 0
> +                       then
> +                               die "$(gettext "path arguments are incompatible with --init-active")"
> +                       fi
> +                       cmd_init "--" $(git config --get-all submodule.active) || return

What happens with submodule.<name>.actives here?