From: Stefan Beller Date: Tue, 26 May 2015 17:37:29 GMT Subject: Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id Message-ID: In-Reply-To: <20150525194007.GH26436@vauxhall.crustytoothpaste.net> On Mon, May 25, 2015 at 12:40 PM, brian m. carlson wrote: > On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: >> [PATCH 01/56] was authored by you but has Michael's sign-off, which >> looked somewhat odd to me, though. > > Yes, it does. He picked it up from me, and signed off, and I took his > branch. I don't believe he changed it, but I didn't check for certain. > So technically, although I wrote it, I also received it from him without > changing it, so both (a) and (c) of the DCO apply. At least in the kernel, the sign offs are also used to track a patchs way of life, so essentially whenever somebody touches that patch (either as an author, or as a patch shoveling sub Lieutenant), you'd add a sign off. So if we were to handle the sign offs just as the kernel people, I would have assumed a sign-off block like Sign-off: you Sign off: Michael Sign-off: you as that would indicate that Michael did not author it from scratch but based his work on yours. That's just my understanding of the sign off process for linux and I guessed we'd follow a very similar process. But no objections from me regarding the signing. All patches have been Skimmed-over-and-run-test-suite-by: Stefan Beller if that helps. > -- > brian m. carlson / brian with sandals: Houston, Texas, US > +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only > OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187