From: Stefan Beller <sbeller@google.com>
Date: Fri, 18 Nov 2016 23:39:02 GMT
Subject: Re: [PATCH 13/16] submodule: teach unpack_trees() to update submodules
Message-ID: <CAGZ79kbxd6PxkBkdyGJOOV4f_LwroStXBDwNZ7RAEX+cL1m51w@mail.gmail.com>
In-Reply-To: <20161116002520.GI66382@google.com>

On Tue, Nov 15, 2016 at 4:25 PM, Brandon Williams <bmwill@google.com> wrote:
> On 11/15, Stefan Beller wrote:
>> +                     int flags = CE_MATCH_IGNORE_VALID|CE_MATCH_IGNORE_SKIP_WORKTREE;
>
> For readability you may want to have spaces between the two flags

done

>
>> +     if (o->index_only
>> +         || (!((old->ce_flags & CE_VALID) || ce_skip_worktree(old))
>> +             && (o->reset || ce_uptodate(old))))
>> +             return 0;
>
> The coding guidelines say that git prefers to have the logical operators
> on the right side like this:

fixed all the coding style issues.