From: Stefan Beller <sbeller@google.com>
Date: Mon, 29 Jun 2015 20:32:56 GMT
Subject: Re: [PATCH v4 40/44] builtin-am: support and auto-detect mercurial patches
Message-ID: <CAGZ79kbnxSD5bm_Bhjy8W2oY+1Mb=is_BcfbT5mGsb44fJE5nQ@mail.gmail.com>
In-Reply-To: <CAGZ79kbO+f2iwTE0dG2zx09SAPR3KTt7T5sw5AFmLuNpo8HG3g@mail.gmail.com>

On Mon, Jun 29, 2015 at 1:32 PM, Stefan Beller <sbeller@google.com> wrote:
> On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan <pyokagan@gmail.com> wrote:
>> +                       tz = tz / (60 * 60) * 100 + tz % (60 * 60);
>
> What happens if we have a negative input not matching a full hour, say -5400 ?
> (would equate to 0130 in git)
>
> for calculating the minutes we would only need to take % 3600 (which
> you do), but
> then we still need to divide by 60 to convert seconds to minutes?
>

That said, I wonder if we have some helper functions around somewhere as we
need to convert the timezone data at many places.