From: Stefan Beller <sbeller@google.com>
Date: Thu, 22 Feb 2018 20:09:05 GMT
Subject: Re: [PATCH v3 07/35] connect: convert get_remote_heads to use struct packet_reader
Message-ID: <CAGZ79kbnioP+12xa2qfaYLyzdeCH8hh2Ri0xHD7rNciJiTYxmg@mail.gmail.com>
In-Reply-To: <20180207011312.189834-8-bmwill@google.com>

> +static enum protocol_version discover_version(struct packet_reader *reader)
> +{
...
> +
> +       /* Maybe process capabilities here, at least for v2 */
> +       switch (version) {
> +       case protocol_v1:
> +               /* Read the peeked version line */
> +               packet_reader_read(reader);
> +               break;
> +       case protocol_v0:
> +               break;
> +       case protocol_unknown_version:
> +               die("unknown protocol version: '%s'\n", reader->line);

The following patches introduce more of the switch(version) cases.
And there it actually is a
    BUG("protocol version unknown? should have been set in discover_version")
but here it is a mere
  die (_("The server uses a different protocol version than we can
speak: %s\n"),
      reader->line);
so I would think here it is reasonable to add _(translation).