From: Stefan Beller <sbeller@google.com>
Date: Tue, 27 Mar 2018 23:53:22 GMT
Subject: Re: [PATCH 3/5] submodule-config: add repository argument to submodule_from_{name, path}
Message-ID: <CAGZ79kbisNdO_9A_sH0w+FU5q6mhtgynd6BuY8UoWaC-X6twbg@mail.gmail.com>
In-Reply-To: <20180327160443.5034f7db908c08fe3c301ab9@google.com>

On Tue, Mar 27, 2018 at 4:04 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
> On Tue, 27 Mar 2018 14:39:16 -0700
> Stefan Beller <sbeller@google.com> wrote:
>
>> -extern const struct submodule *submodule_from_name(
>> +extern const struct submodule *submodule_from_name(struct repository *r,
>>               const struct object_id *commit_or_tree, const char *name);
>> -extern const struct submodule *submodule_from_path(
>> +extern const struct submodule *submodule_from_path(struct repository *r,
>>               const struct object_id *commit_or_tree, const char *path);
>
> There is a recent change to CodingGuidelines that states to not include
> "extern" in 89a9f2c862 ("CodingGuidelines: mention "static" and
> "extern"", 2018-02-08), so consider removing "extern" since you're
> already changing this file.

Gah!

I have that fixed locally; it will be included in the next version

>
> Other than that,
>
> Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

Thanks!