From: Stefan Beller Date: Mon, 09 Apr 2018 17:25:55 GMT Subject: Re: [PATCH v2 0/4] Lazy-load trees when reading commit-graph Message-ID: In-Reply-To: <7930c9bf-4f24-2e76-b522-331a2e9ed5d5@gmail.com> On Mon, Apr 9, 2018 at 6:15 AM, Derrick Stolee wrote: > I don't understand how folding the patches makes the correctness clearer, > since the rename (1/4) is checked by the compiler and the Coccinelle script > (3/4) only works after that rename is complete. > > The only thing I can imagine is that it makes smaller patch emails, since > there is only one large patch instead of two. In this case, I prefer to make > changes that are easier to check by automation (compiler and coccinelle). > I prefer the offloading to automation, too. So I would vouch for keeping it as-is.