From: Stefan Beller <sbeller@google.com>
Date: Wed, 12 Jul 2017 00:04:58 GMT
Subject: Re: [PATCH 3/3] grep: recurse in-process using 'struct repository'
Message-ID: <CAGZ79kbUggNeiijOWdZX__HSd5uZ1M+TnVb2Gkik9AZpZZeQKQ@mail.gmail.com>
In-Reply-To: <20170711220408.173269-4-bmwill@google.com>

On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams <bmwill@google.com> wrote:

> +       if (repo_submodule_init(&submodule, superproject, path))
> +               return 0;

What happens if we go through the "return 0", do we rather want to
print an error ?

> +       /* add objects to alternates */
> +       add_to_alternates_memory(submodule.objectdir);

Not trying to make my object series more important than it is... but
we really don't want to spread this add_to_alternates_memory hack. :/

I agree with Jacob that a patch with such a diffstat is a joy to review. :)

Thanks,
Stefan