From: Stefan Beller <sbeller@google.com>
Date: Mon, 02 Oct 2017 23:20:38 GMT
Subject: Re: [PATCH 13/24] builtin/pack-objects: convert to struct object_id
Message-ID: <CAGZ79kbULxhSAEx6x6+4Q5nCG4pT98AXVfLBMwQHf-Kx4Wzc=Q@mail.gmail.com>
In-Reply-To: <20171001220831.214705-14-sandals@crustytoothpaste.net>

> @@ -2520,17 +2521,17 @@ static void read_object_list_from_stdin(void)
>                         continue;
>                 }
>                 if (line[0] == '-') {
> -                       if (get_sha1_hex(line+1, sha1))
> +                       if (get_oid_hex(line+1, &oid))
>                                 die("expected edge sha1, got garbage:\n %s",
>                                     line);
...

> -               if (get_sha1_hex(line, sha1))
> +               if (parse_oid_hex(line, &oid, &p))
>                         die("expected sha1, got garbage:\n %s", line);

Ideally we do not forget about converting the die() calls, too.