From: Stefan Beller <sbeller@google.com>
Date: Tue, 24 Oct 2017 20:42:28 GMT
Subject: Re: [PATCH 2/4] xdiff-interface: export comparing and hashing strings
Message-ID: <CAGZ79kbJS68qL0=WTZVBfmSDXCii0HT60TGxx2MSiH_cK_tBCw@mail.gmail.com>
In-Reply-To: <9f5c5cd5-9491-3163-60d4-ad36d75981ce@web.de>

On Tue, Oct 24, 2017 at 1:23 PM, René Scharfe <l.s.r@web.de> wrote:

> xdl_recmatch() is already exported; why not use it without this
> wrapper?

It is exported in xdiff/xutils.h, to be used by various xdiff/*.c files, but
not outside of xdiff/. This one makes it available to the outside, too.

>> +extern unsigned long xdiff_hash_string(const char *s, size_t len, long flags);
>
> Documenting the meaning of their parameters would be nice.

I'll do that.