From: Stefan Beller Date: Tue, 18 Nov 2014 01:01:16 GMT Subject: Re: [PATCH] copy.c: make copy_fd preserve meaningful errno Message-ID: In-Reply-To: <20141118004841.GE4336@google.com> On Mon, Nov 17, 2014 at 4:48 PM, Jonathan Nieder wrote: > (meta-comment: please snip out the context you are not responding to, > to make reading easier) will do > > After this patch, setting errno is not part of the contract of > copy_fd, so the bug Ronnie was fixing is gone. > > But it's a little more invasive. What do you think? > I really like that approach and would be happy if we'd take it instead of the one I sent.