From: Stefan Beller <sbeller@google.com>
Date: Mon, 29 Feb 2016 23:39:28 GMT
Subject: Re: [PATCH v6 7/7] git: submodule honor -c credential.* from command line
Message-ID: <CAGZ79kbDaV=i0augzh5RgGYpTWXOuTLx=7Occhc-6iE+0pBVNg@mail.gmail.com>
In-Reply-To: <1456786715-24256-8-git-send-email-jacob.e.keller@intel.com>

On Mon, Feb 29, 2016 at 2:58 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:
>
> +test_expect_success 'cmdline credential config passes into submodules' '
> +       git init super &&
> +       set_askpass user@host pass@host &&

I wonder why we use pass@host as a password, it seems confusing to me.
p@ssword would have worked if we wanted to test a password containing an @,
pass@host doesn't quite fit my mental model of how passwords work.
No need to change anything, better be consistent with the rest of the tests.


> +       (
> +               cd super &&
> +               git submodule add "$HTTPD_URL/auth/dumb/repo.git" sub &&
> +               git commit -m "add submodule"
> +       ) &&
> +       set_askpass wrong pass@host &&
> +       test_must_fail git clone --recursive super super-clone &&
> +       rm -rf super-clone &&
> +       set_askpass wrong pass@host &&

Why set set_askpass a second time here?

> +       git -c "credential.$HTTP_URL.username=user@host" \
> +               clone --recursive super super-clone &&
> +       expect_askpass pass user@host
> +'

Thanks for this test!
Stefan