From: Stefan Beller <sbeller@google.com>
Date: Thu, 21 Jun 2018 21:43:52 GMT
Subject: Re: [PATCH 2/5] commit-graph: add missing forward declaration
Message-ID: <CAGZ79kbC0e1ujAebTUexDXH4+cFOpek3a0VTrdRUfx6Z=cpBVw@mail.gmail.com>
In-Reply-To: <82c9edb9108f49468031bfd7c65a9eb8db2cb671.1529616356.git.jonathantanmy@google.com>

Hi Jonathan,
On Thu, Jun 21, 2018 at 2:29 PM Jonathan Tan <jonathantanmy@google.com> wrote:
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>

Both this and the previous patch look good to me;
you seem to have better (stricter) checking for
missing includes/forward declarations, am I missing
a compile option? (I have DEVELOPER=1 in config.mak)