From: Stefan Beller <sbeller@google.com>
Date: Tue, 23 Oct 2018 00:37:36 GMT
Subject: Re: [PATCH v2 1/1] protocol: advertise multiple supported versions
Message-ID: <CAGZ79kbB6F9Bqx7d=9zAKSt=3Yxpm+nj=jgUA=A2P6X8v0ywMg@mail.gmail.com>
In-Reply-To: <20181022225559.GD233961@google.com>

> > similar to argv_array_pushl  or would that be overengineered?

> Am I missing some other way to do this cleanly? I'll admit I'm not very
> familiar with va_lists.

Ah, you're right. By not passing pointers (and I am unfamiliar
with va_lists, too), this was a moot suggestion.
>
> Yeah, my understanding is that we don't want to assume that version
> identifiers will always be simple integers. We could get away with
> sprintf() for now, but I figured I didn't want to cause future pain
> if/when the version identifiers become complex.

Makes sense.

Stefan