From: Stefan Beller <sbeller@google.com>
Date: Tue, 25 Apr 2017 15:52:48 GMT
Subject: Re: [PATCH] submodule_init: die cleanly on submodules without url defined
Message-ID: <CAGZ79kb9hsvrzc=RnhhyJf-tTnr9rTfV-TQWimYFGwU_Kuew9w@mail.gmail.com>
In-Reply-To: <20170425005746.tulvexabonlexah3@sigill.intra.peff.net>

On Mon, Apr 24, 2017 at 5:57 PM, Jeff King <peff@peff.net> wrote:
> When we init a submodule, we try to die when it has no URL
> defined:
>
>   url = xstrdup(sub->url);
>   if (!url)
>           die(...);
>
> But that's clearly nonsense. xstrdup() will never return
> NULL, and if sub->url is NULL, we'll segfault.
>
> These two bits of code need to be flipped, so we check
> sub->url before looking at it.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---

Makes sense. At the time I assumed xstrdup had a _or_null
behavior (i.e. if NULL goes in, it is not duplicated, but rather
return NULL)

Thanks,
Stefan